Skip to content

Commit

Permalink
Move the xray allowdot feature gate to beta stage (#32694)
Browse files Browse the repository at this point in the history
**Description:** 
Moving xray exporter allow-dot feature gate from alpha to beta stage

It's a follow up change for
#31732

**Testing:** Unit test

**Documentation:** 


https://github.com/XinRanZhAWS/opentelemetry-collector-contrib/blob/f0863f481445e7205e3096a9a536463e3a51de81/.chloggen/xray_exporter_allow_dot_annotation.yaml

Purpose of this feature gate:

In the past, X-Ray doesn’t support “.”. So we have a translator in x-ray
export to translates it to “_” before sending traces to X-Ray Service.

To match otel naming style, x-ray service team decide to change their
service to support both "." type and "" type of naming. In this case the
translator that translate "." to "" is no-longer needed. This PR change
the way this translator work

X-Ray PMs agree on rolling out this change by using feature-gate
  • Loading branch information
XinRanZhAWS authored May 15, 2024
1 parent fec50f0 commit 7ef91f9
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 1 deletion.
27 changes: 27 additions & 0 deletions .chloggen/xrayexporter-dot-converter-featuregate-beta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: awsxrayexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: change x-ray exporter's translator to make "." split annotation pass as-is

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [32694, 31732]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: This change make below change to beta stage for feature gate 'exporter.xray.allowDot',this change will let the change mention below enable by default | In the past, X-Ray doesn’t support “.”. So we have a translator in x-ray export to translates it to “_” before sending traces to X-Ray Service. | To match otel naming style, x-ray service team decide to change their service to support both "." type and "" type of naming. In this case the translator that translate "." to "" is no-longer needed. This PR change the way this translator work | X-Ray PMs agree on rolling out this change by using feature-gate

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [user]
2 changes: 1 addition & 1 deletion exporter/awsxrayexporter/internal/translator/segment.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ var (
var (
remoteXrayExporterDotConverter = featuregate.GlobalRegistry().MustRegister(
"exporter.xray.allowDot",
featuregate.StageAlpha,
featuregate.StageBeta,
featuregate.WithRegisterDescription("X-Ray Exporter will no longer convert . to _ in annotation keys when this feature gate is enabled. "),
featuregate.WithRegisterFromVersion("v0.97.0"),
)
Expand Down

0 comments on commit 7ef91f9

Please sign in to comment.