Skip to content

Commit

Permalink
Bug 18748: Noisy t/db_dependent/AuthorisedValues.t
Browse files Browse the repository at this point in the history
This noise is from a failure. This patch expands the delete
to 952$c for the ACQ framework as per comment #5.

TEST PLAN
---------

insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian, libopac, repeatable, mandatory, kohafield,tab,authorised_value,authtypecode,value_builder,isurl,hidden,frameworkcode,seealso,link,defaultvalue,maxlength) values (952,'c','Shelving location','Shelving location',0,0,'items.location',10,'LOC','','',0,0,'ACQ','','',null,9999);
-- this makes sure you have a pre-existing 952$c ACQ record.

prove t/db_dependent/AuthorisedValues.t
-- should have ugly message like in comment #0
apply patch
prove t/db_dependent/AuthorisedValues.t
-- should be green
run koha qa test tools

Signed-off-by: Lee Jamison <[email protected]>

Signed-off-by: Marcel de Rooy <[email protected]>

Signed-off-by: Jonathan Druart <[email protected]>
(cherry picked from commit 441f6fa)
Signed-off-by: Fridolin Somers <[email protected]>
  • Loading branch information
mtompset authored and fridobox committed Jul 18, 2017
1 parent ecc3bce commit 97498a6
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions t/db_dependent/AuthorisedValues.t
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ subtest 'search_by_*_field + find_by_koha_field + get_description' => sub {
$loc_cat->delete if $loc_cat;
my $mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => 'c', frameworkcode => '' } );
$mss->delete if $mss;
$mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => 'c', frameworkcode => 'ACQ' } );
$mss->delete if $mss;
$mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => 'd', frameworkcode => '' } );
$mss->delete if $mss;
$mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => '5', frameworkcode => '' } );
Expand Down

0 comments on commit 97498a6

Please sign in to comment.