Bug 19004: Patrons.t should create its own data for enrollment fees.

If the patron categories J, K, YA would not exist, Patrons.t would fail. Test plan: [1] Remove one of these patron categories. [2] Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <[email protected]> Signed-off-by: Mark Tompsett <[email protected]> Signed-off-by: Kyle M Hall <[email protected]> Signed-off-by: Jonathan Druart <[email protected]>
open-source-knihovna · Sep 1, 2017 · 57427f7 · 57427f7
1 parent 327495b
commit 57427f7
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
@@ -32,6 +32,7 @@ use C4::Circulation;
 use Koha::Holds;
 use Koha::Patron;
 use Koha::Patrons;
+use Koha::Patron::Categories;
 use Koha::Database;
 use Koha::DateUtils;
 use Koha::Virtualshelves;
@@ -375,14 +376,13 @@ subtest "delete" => sub {
 subtest 'add_enrolment_fee_if_needed' => sub {
     plan tests => 4;
 
-    my $enrolmentfee_K  = 5;
-    my $enrolmentfee_J  = 10;
-    my $enrolmentfee_YA = 20;
-
-    my $dbh = C4::Context->dbh;
-    $dbh->do(q|UPDATE categories set enrolmentfee=? where categorycode=?|, undef, $enrolmentfee_K, 'K');
-    $dbh->do(q|UPDATE categories set enrolmentfee=? where categorycode=?|, undef, $enrolmentfee_J, 'J');
-    $dbh->do(q|UPDATE categories set enrolmentfee=? where categorycode=?|, undef, $enrolmentfee_YA, 'YA');
+    my $enrolmentfees = { K  => 5, J => 10, YA => 20 };
+    foreach( keys %{$enrolmentfees} ) {
+        ( Koha::Patron::Categories->find( $_ ) // $builder->build_object({ class => 'Koha::Patron::Categories', value => { categorycode => $_ } }) )->enrolmentfee( $enrolmentfees->{$_} )->store;
+    }
+    my $enrolmentfee_K  = $enrolmentfees->{K};
+    my $enrolmentfee_J  = $enrolmentfees->{J};
+    my $enrolmentfee_YA = $enrolmentfees->{YA};
 
     my %borrower_data = (
         firstname    => 'my firstname',