Skip to content

Commit

Permalink
Bug 18630: Translatability (Clubs): 'Cancel' is ambiguous and leads t…
Browse files Browse the repository at this point in the history
…o mistakes

The button to cancel a club enrollement is labelled with 'Cancel'. That is ambiguous and translates e.g. in German to 'Abbrechen' which can lead to
mistakes.

To test:
- Apply patch
- Enroll a patron to a club
- Enable public enrollment in OPAC
- Verify that the button to cancel enrollment in both OPAC and staff client
  reads 'Cancel enrollement' (instead of 'Cancel' without patch)
  (The button appears on the patron's detail pages in OPAC and staff client)

Amended for comment #4 / mv

Signed-off-by: Josef Moravec <[email protected]>

Signed-off-by: Kyle M Hall <[email protected]>

Signed-off-by: Jonathan Druart <[email protected]>
(cherry picked from commit 628d839)
Signed-off-by: Fridolin Somers <[email protected]>
  • Loading branch information
veronch authored and fridobox committed Jun 27, 2017
1 parent d6eb92b commit 00ebb05
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
[% IF CAN_user_clubs_enroll %]
<td>
<button class="btn btn-xs btn-default" onclick="cancelEnrollment( [% e.id %] )">
<i class="fa fa-remove"></i> Cancel
<i class="fa fa-remove"></i> Cancel enrollment
</button>
</td>
[% END %]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
[% IF e.club.club_template.is_enrollable_from_opac %]
<td>
<button class="btn btn-xs btn-default" onclick="cancelEnrollment( [% e.id %] )">
<i class="icon-remove"></i> Cancel
<i class="icon-remove"></i> Cancel enrollment
</button>
</td>
[% END %]
Expand Down

0 comments on commit 00ebb05

Please sign in to comment.