-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear all stored trend values when changing active trend. #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clearing data for the inactive plots really made a difference 👍
Fix looks good.
Tested with CI artifact.
Nice improvement! Now, the application becomes more responsive when not in the trend view. Whenever entering the trend view, we first see the empty plot for a few seconds (here, time will vary depending on how many variables and which time span is selected). |
I believe I might have found a small issue: Setup:
Action 1:
Result 1:
Action 2:
Result 2:
It seems that when switching from Plot2 to Plot1, the timespan of plot 2 is retained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above.
I can't reproduce this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed over teams, I have checked your last commit.
It seems the issue I have reported is now fixed. Nice!
Fixes #175 by removing all stored trend data when navigating to/from a plot.
If the user is looking at a lot of trend data (long time span, many variables etc), the whole application can slow down. By navigating away from the plot the application will become snappy again.
Consequence: When navigating to a plot, it can take 3-4 seconds before any data appears. Before the fix, old data was shown in the mean time.Update; I have created a little shortcut such that when navigating to a plot, the initial data is generated much faster than before.