Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMH: Fix spelling errors in comments and strings #406

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

psco
Copy link
Contributor

@psco psco commented Jul 11, 2024

Over the years the SIMH base components files have accumulated some spelling errors. This PR fixes almost 200 typos. Note that only typos in comments and string literals are taken care of.

@markpizz
Copy link
Contributor

I'm always a little concerned about changes that affect many files. Historically, it was appropriate to changes this type of issue in files when other changes were made to that file. However many of these files never change and have had these minor issues forever, so such a change would seem appropriate to be part of a global cleanup.

In your microscopic review of all of this, you might have found a couple of bugs along the way. If you did, it seems you kept the focus of these changes to on scope "Fix spelling errors in comments and strings". Hopefully you will later come along to address any such bugs found.

I'm good with this global cleanup.

Thanks @psco

@pkoning2
Copy link
Member

Agree with @markpizz -- thanks for this work!

@pkoning2 pkoning2 merged commit 0f6bcb9 into open-simh:master Jul 11, 2024
19 checks passed
@markpizz
Copy link
Contributor

FYI, this change includes minor sim_card changes which should find their way back into @rcornwell's sims repo...

@psco psco deleted the spelling branch July 11, 2024 19:51
@rcornwell
Copy link
Member

Getting time I need to resync my SCP anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants