-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AltairZ80: Adds SET CPU RESIZEMEMORY and other #347
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @deltecent ,
thank you for submitting these useful additions. One minor comment that I’d like to see the mapping/unmapping prints only when VERBOSE is set, ie:
Unmapping memory 0x0f300, handler=jadeprom
Mapping memory 0x0f000, handler=jadeprom
Thanks!
Changing the CPU type or MEMORY size/configuration causes memory resources mapped by other devices to be removed. This is not made clear by "HELP CPU" and the user has no feedback that this is happening. This PR does the following: 1) HELP SET CPU shows that SET CPU MEMORY requires a value. 2) Feedback is provided if the value is omitted or not properly formatted. 3) Unmapped memory resources caused by a SET CPU command are displayed on the SIMH console. 4) Adds a SET CPU RESIZEMEMORY command that resizes system memory without unmapping other device memory resources.
8c5df1c
to
f322156
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @deltecent , the change looks ok to me. What do you think, @psco ?
Thank you @deltecent , this looks fine and can be merged. |
Changing the CPU type or MEMORY size/configuration causes memory resources mapped by other devices to be removed. This is not made clear by
HELP CPU
and the user has no feedback that this is happening.This PR does the following:
HELP SET CPU
now shows thatSET CPU MEMORY
requires a value.SET CPU
command is now displayed on the SIMH console.SET CPU RESIZEMEMORY
command that resizes system memory without unmapping other device memory resources.