Feature/graph names and widths #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a data structure in the YAML files to save parameters about graphs, such as their default width (currently hard-coded to 1 meter) as well as their names. This is a first step towards #378 and is also useful for making traffic lanes for robots other than "typical width" (larger or smaller) than can fit through common doorways. Signed-off-by: Morgan Quigley <[email protected]>
Signed-off-by: Morgan Quigley <[email protected]>
Signed-off-by: Morgan Quigley <[email protected]>
Signed-off-by: Morgan Quigley <[email protected]>
luca-della-vedova
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top-level graph parameters in YAML
Working towards #378 , this PR provides a new
graphstop-level dict in the YAML files. Entries in this dict can map graphs (currently only identified by their integer ID) to human-readable names. Graphs can also have a default lane width, to avoid having to set lane width on each individual lane segment. Thisgraphstop-level dict is optional; there will be no change when viewing or saving existing files. Adding GUI widgets to add or edit these parameters will come in a subsequent PR; for now, you can hand-edit the YAML.Better font scaling for vertex names
Previously, vertex names were rendered with a hard-coded font size. This made them seem too-small or too-large depending on the map scale. The
Level::draw()function now computes a reasonable font size and reuses it for eachVertex::draw()call; previously it was creating a hard-coded font and throwing it away after rendering each vertex, which was slow when rendering very large maps.