-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactive easy full control #286
Reactive easy full control #286
Conversation
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
…trol API Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Thanks for the revamp! Still testing the fleet adapter in various worlds and scenarios, so far it's looking really great. A |
Sure, we can expose that in this PR. We might want to consider thinking of names that make their purpose more clear, but nothing comes to mind for me at the moment. I'd suggest implementing it similarly to For changing the values live we can add APIs to |
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Xiyu Oh <[email protected]> Signed-off-by: Michael X. Grey <[email protected]> Co-authored-by: Michael X. Grey <[email protected]>
This PR significantly revises the implementation of the
EasyFullControl
API by making it reactive instead of running in a thread. It also tweaks the API itself in a way that I believe is much simpler for system integrators, especially for users of the Python bindings. I've also revised the API to be future-proof by using more PIMPL classes instead of basic data types.In the process of testing this new API, I encountered pre-existing several bugs that had been reported before but were difficult to reproduce. This PR includes fixes for the following issues:
I'm creating this as a separate PR that targets #235 so that reviewers can have a more clear idea of what changes are being introduced and why.
To test out this PR, it should be used in conjunction with open-rmf/rmf_demos#188