Fixed Build/Runtime errors + Dockerized #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Pull Request
This pull request targets the following faulty python code statements causing build/runtime errors when attempting to build
door_adapter_template
ROS 2 package.Fixed bug 🐛
Build Error: faulty string literal - Bug 1
Runtime Error: faulty import of DoorClientAPI class - Bug 2
Build Error: Missing maintainer email - Bug 3
Fix applied 🐛 🤛
colcon build
as well as observed no further runtime error when running.door_adapter_template
throughoutdoor_adapter_template
ROS 2 package, replacing instances ofdoor_adapter
New feature implementation ➕
Dockerised
door_adapter_template
to ensure ease-of-setup for future developers as well as provided up-to-date instructions on how to use it properly.Implemented features
Dockerfile
based on ROS 2 Humble.README.md
Implementation description
Please run the commands below to verify that
door_adapter_template
faces no build errors when compiling withcolcon build
and no runtime errors when running:cd door_adapter_template
docker build -t door_adapter_template:humble .
docker run -it --rm \ --name door_adapter_template_c \ --network host \ -v /dev/shm:/dev/shm \ -v ./door_adapter_template/config.yaml:/door_adapter_template_ws/src/door_adapter_template/config.yaml \ door_adapter_template:humble /bin/bash -c \ "source /ros_entrypoint.sh && ros2 run door_adapter_template door_adapter --config_file /door_adapter_template_ws/src/door_adapter_template/config.yaml"