Update test_kem exception logic

Signed-off-by: Vlad Gheorghiu <[email protected]>
open-quantum-safe · Jan 15, 2025 · bdcf37f · bdcf37f
1 parent eb55cbc
commit bdcf37f
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/unit_tests/tests/test_kem.cpp b/unit_tests/tests/test_kem.cpp
@@ -52,18 +52,20 @@ void test_kem_wrong_ciphertext(const std::string& kem_name) {
     oqs::bytes wrong_ciphertext = oqs::rand::randombytes(ciphertext.size());
     oqs::bytes shared_secret_client;
     try {
+        // this line should throw
         shared_secret_client = client.decap_secret(wrong_ciphertext);
+        // if not, test should fail
+        bool is_valid = (shared_secret_client == shared_secret_server);
+        if (is_valid)
+            std::cerr << kem_name << ": shared secrets should not coincide"
+                      << std::endl;
+        EXPECT_FALSE(is_valid);
     } catch (std::exception& e) {
         if (e.what() == std::string{"Can not decapsulate secret"})
             return;
         else
             throw; // this is another un-expected exception
     }
-    bool is_valid = (shared_secret_client == shared_secret_server);
-    if (is_valid)
-        std::cerr << kem_name << ": shared secrets should not coincide"
-                  << std::endl;
-    EXPECT_FALSE(is_valid);
 }
 
 TEST(oqs_KeyEncapsulation, Correctness) {