Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support expansion in gator verify #3650

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: support expansion in gator verify #3650

wants to merge 6 commits into from
+275 −8

Conversation

David-Jaeyoon-Lee
Copy link
Contributor

What this PR does / why we need it:
It allows for expansion in gator verify.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3432

Special notes for your reviewer:

@David-Jaeyoon-Lee David-Jaeyoon-Lee requested a review from a team as a code owner October 16, 2024 21:17
@David-Jaeyoon-Lee David-Jaeyoon-Lee marked this pull request as draft October 16, 2024 21:17
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.74627% with 33 lines in your changes missing coverage. Please review.

Project coverage is 47.68%. Comparing base (3350319) to head (8339ab4).
Report is 172 commits behind head on master.

Files with missing lines Patch % Lines
pkg/gator/verify/runner.go 59.64% 16 Missing and 7 partials ⚠️
pkg/gator/reader/read_resources.go 0.00% 10 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (8339ab4). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (8339ab4)
unittests 2 1
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3650      +/-   ##
==========================================
- Coverage   54.49%   47.68%   -6.82%     
==========================================
  Files         134      236     +102     
  Lines       12329    19777    +7448     
==========================================
+ Hits         6719     9430    +2711     
- Misses       5116     9461    +4345     
- Partials      494      886     +392
Flag Coverage Δ
unittests 47.68% <50.74%> (-6.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JaydipGabani
JaydipGabani reviewed Oct 22, 2024
View reviewed changes
pkg/gator/errors.go Outdated Show resolved Hide resolved
pkg/gator/verify/runner.go Outdated Show resolved Hide resolved
@JaydipGabani
Copy link
Contributor

Are we going to add expannsionTemplate to suite?

@David-Jaeyoon-Lee David-Jaeyoon-Lee marked this pull request as ready for review October 24, 2024 22:55
@maxsmythe maxsmythe requested a review from a team October 25, 2024 23:52
maxsmythe
maxsmythe requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small nits

pkg/gator/errors.go Show resolved Hide resolved
pkg/gator/reader/read_constraints.go Outdated Show resolved Hide resolved
pkg/gator/verify/runner.go Show resolved Hide resolved
@ritazh ritazh added this to the v3.18.0 milestone Oct 30, 2024
@David-Jaeyoon-Lee David-Jaeyoon-Lee force-pushed the davjlee/feature/gator-verify-expansion branch from b15146f to f9e6699 Compare October 30, 2024 20:16
JaydipGabani
JaydipGabani requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@David-Jaeyoon-Lee LGTM after gator tests are modified for expansion template, this might help adding those tests David-Jaeyoon-Lee#2.

@David-Jaeyoon-Lee
Copy link
Contributor Author

David-Jaeyoon-Lee commented Oct 31, 2024 •
edited
Loading

@David-Jaeyoon-Lee LGTM after gator tests are modified for expansion template, this might help adding those tests David-Jaeyoon-Lee#2.

I think I added similar tests in this pr already. Or am I misunderstanding something? What specifically do we want to modify?

Edit: Nevermind I see

@David-Jaeyoon-Lee David-Jaeyoon-Lee force-pushed the davjlee/feature/gator-verify-expansion branch from d3892b4 to 8339ab4 Compare November 4, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaydipGabani JaydipGabani JaydipGabani approved these changes

@maxsmythe maxsmythe Awaiting requested review from maxsmythe

@ritazh ritazh Awaiting requested review from ritazh

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.18.0
Development

Successfully merging this pull request may close these issues.

source:generated within constraint.yaml causes gator verify to fail
5 participants
@David-Jaeyoon-Lee @codecov-commenter @JaydipGabani @ritazh @maxsmythe