Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update lint #3338

Merged
merged 11 commits into from
Mar 28, 2024
Merged

chore: update lint #3338

merged 11 commits into from
Mar 28, 2024

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Mar 27, 2024

Signed-off-by: Sertac Ozercan [email protected]What this PR does / why we need it:

merge after #3323 (aligns with go 1.22). i will rebase after #3323 merges

  • seperates lint, check-manifest, unit test, gator test to their own workflows
  • add missing k8s matrix to gator test
  • updates from golangci-lint action to binary
  • fixes lint errors
  • bumps to latest version at this time (0.57.1)
  • updates deprecated run.skip-files to issues.exclude-files

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@sozercan sozercan requested a review from a team as a code owner March 27, 2024 21:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.73%. Comparing base (3350319) to head (4076db7).
Report is 50 commits behind head on master.

Files Patch % Lines
pkg/controller/controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3338      +/-   ##
==========================================
- Coverage   54.49%   46.73%   -7.76%     
==========================================
  Files         134      218      +84     
  Lines       12329    14784    +2455     
==========================================
+ Hits         6719     6910     +191     
- Misses       5116     7072    +1956     
- Partials      494      802     +308     
Flag Coverage Δ
unittests 46.73% <80.00%> (-7.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/lint.yaml Outdated Show resolved Hide resolved
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
Signed-off-by: Sertac Ozercan <[email protected]>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this!

@sozercan sozercan merged commit 07fae2f into open-policy-agent:master Mar 28, 2024
19 checks passed
@sozercan sozercan deleted the lint branch March 28, 2024 20:47
leewoobin789 pushed a commit to softlee-io/gatekeeper that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants