use vap binding in constraint controller

Signed-off-by: Avinash Patnala <[email protected]>
open-policy-agent · Oct 23, 2024 · 78f720f · 78f720f
1 parent fcde683
commit 78f720f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/pkg/controller/constraint/constraint_controller.go b/pkg/controller/constraint/constraint_controller.go
@@ -347,7 +347,7 @@ func (r *ReconcileConstraint) Reconcile(ctx context.Context, request reconcile.R
 			r.log.Info("constraint controller", "generateVAPB", generateVAPB)
 			// generate vapbinding resources
 			if generateVAPB && groupVersion != nil {
-				currentVapBinding, err := transform.VapForVersion(groupVersion)
+				currentVapBinding, err := transform.VapBindingForVersion(*groupVersion)
 				if err != nil {
 					return reconcile.Result{}, r.reportErrorOnConstraintStatus(ctx, status, err, "could not get ValidatingAdmissionPolicyBinding API version")
 				}
@@ -388,7 +388,7 @@ func (r *ReconcileConstraint) Reconcile(ctx context.Context, request reconcile.R
 			// do not generate vapbinding resources
 			// remove if exists
 			if !generateVAPB && groupVersion != nil {
-				currentVapBinding, err := transform.VapForVersion(groupVersion)
+				currentVapBinding, err := transform.VapBindingForVersion(*groupVersion)
 				if err != nil {
 					return reconcile.Result{}, r.reportErrorOnConstraintStatus(ctx, status, err, "could not get ValidatingAdmissionPolicyBinding API version")
 				}

diff --git a/pkg/drivers/k8scel/transform/vap_util.go b/pkg/drivers/k8scel/transform/vap_util.go
@@ -90,3 +90,14 @@ func VapForVersion(gvk *schema.GroupVersion) (client.Object, error) {
 		return nil, errors.New("unrecognized version")
 	}
 }
+
+func VapBindingForVersion(gvk schema.GroupVersion) (client.Object, error) {
+	switch gvk.Version {
+	case "v1":
+		return &admissionregistrationv1.ValidatingAdmissionPolicyBinding{}, nil
+	case "v1beta1":
+		return &admissionregistrationv1beta1.ValidatingAdmissionPolicyBinding{}, nil
+	default:
+		return nil, errors.New("unrecognized version")
+	}
+}