Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Remove Double Minus Sign in DI Email Templates #18802

Merged
merged 1 commit into from
Nov 27, 2024
Merged

FIX: Remove Double Minus Sign in DI Email Templates #18802

merged 1 commit into from
Nov 27, 2024
+1 −2

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Nov 26, 2024 •
edited
Loading

Describe your changes:

Remove double minus sign coming in percentChangeMessage in DI email template.

image (5)

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline Siddhanttimeline added the safe to test Add this label to run secure Github workflows on PRs label Nov 26, 2024
@Siddhanttimeline Siddhanttimeline self-assigned this Nov 26, 2024
@Siddhanttimeline Siddhanttimeline requested a review from a team as a code owner November 26, 2024 22:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit 15f56c1 into main Nov 27, 2024
24 of 36 checks passed
@chirag-madlani chirag-madlani deleted the fix-DI-email-template branch November 27, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull approved these changes

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees

@Siddhanttimeline Siddhanttimeline

Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Siddhanttimeline @chirag-madlani @pmbrull