Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Allow Asset add and remove operation for editTag permission user #18786

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

WIP: Allow Asset add and remove operation for editTag permission user #18786

wants to merge 6 commits into from
+307 −14

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.83% (40246/63049) 40.39% (16050/39734) 42.68% (4792/11229)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11 ShaileshParmar11 will be requested when the pull request is marked ready for review ShaileshParmar11 is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 will be requested when the pull request is marked ready for review karanh37 is a code owner

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani will be requested when the pull request is marked ready for review chirag-madlani is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya will be requested when the pull request is marked ready for review Sachin-chaurasiya is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @sonika-shah