Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR - fix(elasticsearch): add None value filter #18711

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

AstEfTech
Copy link

Describe your changes:

Added None values filter to elasticsearch returned results

Fixes None

Sometimes elasticsearch returns lists with None values in it. To fix this issue we need to filter them out first, befor returning most relevant to the endpoint.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.

Sometimes elasticsearch returns lists with None values in it.
To fix this issue we need to filter them out first, befor returning most relevant to the endpoint.
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@AstEfTech AstEfTech changed the title fix(elasticsearch.py) - add None value filter fix(elasticsearch): add None value filter Nov 20, 2024
@AstEfTech AstEfTech changed the title fix(elasticsearch): add None value filter MINOR - fix(elasticsearch): add None value filter Nov 20, 2024
@AstEfTech
Copy link
Author

None values can be first in the list, that's why we can filter them out before future processing

@TeddyCr
Copy link
Contributor

TeddyCr commented Nov 26, 2024

@AstEfTech you have a few tests failures, once you fix those happy to merge it 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants