Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for lineage export #18709

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Add test for lineage export #18709

merged 4 commits into from
Nov 22, 2024

Conversation

sweta1308
Copy link
Contributor

I worked on adding the tests for lineage export.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@karanh37 karanh37 changed the base branch from main to fix_lineage_export November 22, 2024 11:33
@karanh37 karanh37 requested review from a team as code owners November 22, 2024 11:33
@karanh37 karanh37 merged commit 5fb1d9e into open-metadata:fix_lineage_export Nov 22, 2024
8 of 15 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

harshach added a commit that referenced this pull request Nov 22, 2024
@harshach @karanh37 @sweta1308
Minor: fix Lineage export when there is no column / pipeline edge (#1…
9484d83 
…8737)

* Minor: fix Lineage export when there is no column / pipeline edge

* add test for lineage export (#18709)

Co-authored-by: Karan Hotchandani <[email protected]>

* add lineage export tests

---------

Co-authored-by: Karan Hotchandani <[email protected]>
Co-authored-by: Sweta Agarwalla <[email protected]>
Co-authored-by: karanh37 <[email protected]>
karanh37 pushed a commit that referenced this pull request Nov 22, 2024
@harshach @karanh37
Minor: fix Lineage export when there is no column / pipeline edge (#1…
49441e2 
…8737)

* Minor: fix Lineage export when there is no column / pipeline edge

* add test for lineage export (#18709)

Co-authored-by: Karan Hotchandani <[email protected]>

* add lineage export tests

---------

Co-authored-by: Karan Hotchandani <[email protected]>
Co-authored-by: Sweta Agarwalla <[email protected]>
Co-authored-by: karanh37 <[email protected]>
(cherry picked from commit 9484d83)
harshach added a commit that referenced this pull request Nov 24, 2024
@harshach @karanh37 @sweta1308
Minor: fix Lineage export when there is no column / pipeline edge (#1…
f220606 
…8737)

* Minor: fix Lineage export when there is no column / pipeline edge

* add test for lineage export (#18709)

Co-authored-by: Karan Hotchandani <[email protected]>

* add lineage export tests

---------

Co-authored-by: Karan Hotchandani <[email protected]>
Co-authored-by: Sweta Agarwalla <[email protected]>
Co-authored-by: karanh37 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweta1308 @karanh37