Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 18156: upgrade pyiceberg; add optional OAuth2 scope #18669

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MChamberlin
Copy link
Contributor

@MChamberlin MChamberlin commented Nov 16, 2024

Describe your changes:

Fixes 18156, 17797

  • Upgrade pyiceberg to version 0.7.1, which includes support for custom OAuth2 Scope.
  • Add OAuth2 scope parameter to the database service connection configuration for Iceberg REST Catalogs.

Context

It is often necessary to provide an OAuth2 scope along with client credentials for an Iceberg REST Catalog connection, particularly for the Apache Polaris REST catalog. Here we add the ability to configure a scope for an Iceberg REST catalog connection in an Iceberg database ingestion service. We also upgrade pyiceberg and associated dependencies to the latest version (0.7.1), which now supports specifying a custom scope in the REST catalog config.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@MChamberlin MChamberlin changed the title Fixes 18156: upgrde pyiceberg; add optional OAuth2 scope Fixes 18156: upgrade pyiceberg; add optional OAuth2 scope Nov 16, 2024
@sushi30 sushi30 added the safe to test Add this label to run secure Github workflows on PRs label Nov 18, 2024
Copy link
Contributor

github-actions bot commented Nov 18, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.57% (39788/62593) 40.19% (15796/39307) 42.33% (4723/11158)

Copy link

sonarcloud bot commented Nov 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
2 participants