Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): GEN-1690 sso token refresh issue for OIDC #18668

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

fix(ui): GEN-1690 sso token refresh issue for OIDC #18668

wants to merge 8 commits into from
+61 −78

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Nov 16, 2024 •
edited
Loading

Describe your changes:

Fixes: GEN-1690

Fixes:

  • Issue with infinite loop on refresh call
  • Refresh not working for OIDC

Testing done:

  • Keycloak with refresh with multi tabs
  • Okta with Refresh with multi tabs
  • Azure with Refresh with multi tabs
  • Basic / LDAP with refresh with multi tabs
  • SAML with refresh with multi tabs
  • Auth0 with refresh with multi tabs
  • Confidential with refresh with multi tabs

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Nov 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.59% (39839/62648) 40.15% (15812/39385) 42.33% (4724/11159)

@chirag-madlani chirag-madlani changed the title fix(ui): sso token refresh issue for OIDC fix(ui): GEN-1690 sso token refresh issue for OIDC Nov 21, 2024
@notion-workspace Notion Workspace
Copy link

User Getting Signed Out, need to investigate refresh

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11 ShaileshParmar11 will be requested when the pull request is marked ready for review ShaileshParmar11 is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 will be requested when the pull request is marked ready for review karanh37 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag-madlani @Sachin-chaurasiya