Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async apis for csv import #18647

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Add async apis for csv import #18647

wants to merge 21 commits into from

Conversation

sonika-shah
Copy link
Contributor

@sonika-shah sonika-shah commented Nov 14, 2024 •
edited by Sachin-chaurasiya
Loading

Describe your changes:

Added the async support for import assets.

GLOSSARY_IMPORT.mov

Type of change:

  • Improvement
  • New feature

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sonika-shah sonika-shah added backend safe to test Add this label to run secure Github workflows on PRs labels Nov 14, 2024
@sonika-shah sonika-shah requested a review from a team as a code owner November 14, 2024 14:22
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonika-shah
Merge branch 'main' into import-csv-async
48abb02 
# Conflicts:
#	openmetadata-service/src/main/java/org/openmetadata/service/resources/EntityResource.java
#	openmetadata-service/src/main/java/org/openmetadata/service/util/WebsocketNotificationHandler.java
@sonika-shah sonika-shah marked this pull request as draft November 19, 2024 03:48
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonika-shah sonika-shah marked this pull request as ready for review November 19, 2024 03:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@ShaileshParmar11 ShaileshParmar11 Awaiting requested review from ShaileshParmar11 ShaileshParmar11 is a code owner

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sonika-shah @chirag-madlani @Sachin-chaurasiya