Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added course category filtering menu to My Courses #76

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

upats
Copy link

@upats upats commented Jul 13, 2017

I migrated all of the less customizations over to sass to work properly now that Snap is using Boost as the parent theme. This fork is up to date with moodlerooms' snap master branch.

One thing that should probably get added is a theme setting to enable/disable this new feature.

@gthomas2
Copy link
Contributor

gthomas2 commented Aug 1, 2017

Thanks for the PR, I will be trying this out today and hopefully will demo to Snap team soon.

@upats
Copy link
Author

upats commented Aug 1, 2017

@gthomas2 the latest commit in our master branch has added a theme setting to enable/disable the category filtering

@gthomas2
Copy link
Contributor

gthomas2 commented Aug 2, 2017

@upats Thank you for offering your Snap customisation for inclusion in the Snap codebase. Although there will be benefits to some institutions and user types, we have to focus the UI on the most common types. We appreciate that there is a flag to turn the feature on and off but there will be an additional amount of development effort for us to accommodate it as we work on planned changes to the personal menu - e.g. filtering by current, past and future courses. We really appreciate the hard work you put into your customization, but unfortunately we can't accept it at this time. Please do consider filing pull requests for any future customizations or fixes in the future.

@upats
Copy link
Author

upats commented Aug 2, 2017

@gthomas2 thanks for the consideration. One reason @mouneyrac and I designed this modification is so additional sorting/filtering could be easily added to it--for example your current, past, and future courses. Right now there are only two: All courses, Categories.

We did not know what Moodlerooms' future user menu would look like so we took some liberties and designed the UI as it stands in our forked version. If the UI will be changing to accommodate these new past, current, future course filtering, might I suggest designing it in a way that allows us to add our Category filtering option to it?

@gthomas2
Copy link
Contributor

gthomas2 commented Aug 3, 2017

@upats - We will definitely keep that in mind when working on course filtering.

@upats
Copy link
Author

upats commented Aug 3, 2017

Thanks! I appreciate it.

@sonyaIDT
Copy link

@gthomas2 - Sorry to chip in on an old conversation...

Regarding the personal menu - are there perhaps plans to filter courses by completion status? The ability to filter by course end-date is helpful, but most of our courses are completed when a specific grade / progress is reached.

@gthomas2
Copy link
Contributor

@sonyaIDT sadly I am no longer part of the team developing Snap so I can't speak for any future plans. In the version for 3.3 we added the category id as a data attribute with the intention of that being used for category filtering. The same approach would work for completion status I guess. @upats, copying you in as that information may be useful to you.

@upats
Copy link
Author

upats commented May 21, 2018

Hi all,

Just wanted to circle back around to this. I notice the latest version of snap includes filtering by course year. Any chance the team might consider implementing an some other course filtering options, similar to what this pull request does? We have courses that aren't tied to a specific year and it would be great to have a context to filter them by (i.e. the course category they belong to).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants