Setting preference maybe rollback when execute multiple targetcli requests concurrently #188

zoumingzhe · 2021-10-22T05:34:37Z

ConfigShell always initialization new Console object.

However, the lockfile need to be opened before requesting flock.
At this time, an exception may occur and need to be output to the console.
Currently, ConfigShell always initializes a new Console object.
So, ConfigShell is initialized first to be able to print information.
The prefs.bin file will be loaded when ConfigShell is initialized.
In this case, the old value may be read, if a new preference is being set and not saved.
Even worse, if this is also a setting command, the previous setting will be rolled back.

Setting preference maybe rollback when execute multiple targetcli requests concurrently. Please see open-iscsi/targetcli-fb#188 for details. In order to solve this problem we must first initialize a Console object. Signed-off-by: Zou Mingzhe <[email protected]>

zoumingzhe mentioned this issue Oct 22, 2021

ConfigShell support passing Console object as parameter open-iscsi/configshell-fb#62

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setting preference maybe rollback when execute multiple targetcli requests concurrently #188

Setting preference maybe rollback when execute multiple targetcli requests concurrently #188

zoumingzhe commented Oct 22, 2021 •

edited

Loading

Setting preference maybe rollback when execute multiple targetcli requests concurrently #188

Setting preference maybe rollback when execute multiple targetcli requests concurrently #188

Comments

zoumingzhe commented Oct 22, 2021 • edited Loading

zoumingzhe commented Oct 22, 2021 •

edited

Loading