ConfigShell support passing Console object as parameter #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting preference maybe rollback when execute multiple targetcli requests concurrently. Please see open-iscsi/targetcli-fb#188 for details. In order to solve this problem we must first initialize a Console object. Signed-off-by: Zou Mingzhe <[email protected]>
zoumingzhe
added a commit
to zoumingzhe/targetcli-fb
that referenced
this pull request
Oct 22, 2021
Setting preference maybe rollback when execute multiple targetcli requests concurrently. ConfigShell always initialization new Console object. However, the lockfile need to be opened before requesting flock. At this time, an exception may occur and need to be output to the console. Currently, ConfigShell always initializes a new Console object. So, ConfigShell is initialized first to be able to print information. The prefs.bin file will be loaded when ConfigShell is initialized. In this case, the old value may be read, if a new preference is being set and not saved. In order to solve this problem we must first initialize a Console object. This patch needs open-iscsi/configshell-fb#62 to be merged first. Signed-off-by: Zou Mingzhe <[email protected]>
zoumingzhe
added a commit
to zoumingzhe/targetcli-fb
that referenced
this pull request
Oct 22, 2021
Setting preference maybe rollback when execute multiple targetcli requests concurrently. ConfigShell always initialization new Console object. However, the lockfile need to be opened before requesting flock. At this time, an exception may occur and need to be output to the console. Currently, ConfigShell always initializes a new Console object. So, ConfigShell is initialized first to be able to print information. The prefs.bin file will be loaded when ConfigShell is initialized. In this case, the old value may be read, if a new preference is being set and not saved. In order to solve this problem we must first initialize a Console object. This patch needs open-iscsi/configshell-fb#62 to be merged first. Signed-off-by: Zou Mingzhe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting preference maybe rollback when execute multiple targetcli requests concurrently.
Please see open-iscsi/targetcli-fb#188 for details.
In order to solve this problem we must first initialize a Console object.
Signed-off-by: Zou Mingzhe [email protected]