-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Allow to use bucket storage policy #220
base: 1.x
Are you sure you want to change the base?
[WIP] Allow to use bucket storage policy #220
Conversation
f166759
to
f58dca4
Compare
f58dca4
to
4a58605
Compare
4a58605
to
e4ee404
Compare
e4ee404
to
2d0041a
Compare
if memcache is not None: | ||
memcache_key = "/".join( | ||
("versioning", self.account_name, root_container)) | ||
version_policy = memcache.get(memcache_key) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it possible to put that somewhere in the container sysmeta? This would allow to use the usual cache functions (e.g. clear_info_cache
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A functional test should be nice
Enable or disable the use of bucket storage policy.
When enabled, and if a storage policy is defined for a bucket (root container), all objects in this bucket will be uploaded with this storage policy.
The bucket storage policy can optionally be kept in the cache with its old value. To force the update of this value, it is enough to modify a property of this bucket via the AWS CLI (for example: add a tag).