Issue1337 temperature setpoint partial zone

[jelgerjansen]

This PR addresses issue #1337.

[lucasverleyen]

@annadellisola @jelgerjansen thanks for addressing this issue! It's already looking great. I have added a few comments.

[kldjonge]

Good enhancement!

Suggestion to better clarify in de documentation/parameter description that the ventilation heat losses are not considered now.

Alternatively, an (advanced) parameter could be added for a manual input of the design ventilation heat losses of the zone.

[jelgerjansen]

@kldjonge I'll update the documentation regarding the ventilation losses now, and I'll open a new issue to add an implementation of the ventilation losses to the zone and/or ventilation model.

[jelgerjansen]

@kldjonge I added some documentation (see 6908181). Could you let me know whether you agree with this?
@lucasverleyen could you also approve this PR or indicate some changes you would still like to see?

I've already created a new issue (#1395) to include a ventilation term in the Q_design of the building envelope. We can also use that issue to update some other design loss assumptions. E.g. the default for fRH is 22 for example, but the Belgian norm (NBN EN 12831-1 ANB:2020) mentions that reheating is typically not considered for residential buildings and/or heating systems with floor heating (due to slow dynamics).

[kldjonge]

@kldjonge I added some documentation (see 6908181). Could you let me know whether you agree with this?

Looks good!

I've already created a new issue (#1395) to include a ventilation term in the Q_design of the building envelope. We can also use that issue to update some other design loss assumptions. E.g. the default for fRH is 22 for example, but the Belgian norm (NBN EN 12831-1 ANB:2020) mentions that reheating is typically not considered for residential buildings and/or heating systems with floor heating (due to slow dynamics)

Good idea about the fRH, 22 is a rather high value to select even for radiators, even as a default for radiators I believe.

[lucasverleyen]

@kldjonge I added some documentation (see 6908181). Could you let me know whether you agree with this? @lucasverleyen could you also approve this PR or indicate some changes you would still like to see?

Looks good, thanks for considering my comments! I'll approve this pull request.

I've already created a new issue (#1395) to include a ventilation term in the Q_design of the building envelope. We can also use that issue to update some other design loss assumptions. E.g. the default for fRH is 22 for example, but the Belgian norm (NBN EN 12831-1 ANB:2020) mentions that reheating is typically not considered for residential buildings and/or heating systems with floor heating (due to slow dynamics).

I fully agree!