Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable soft-required validation in the form designer #4755

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

sergei-maertens
Copy link
Member

@sergei-maertens sergei-maertens commented Oct 14, 2024

Partially closes #4546 - depends on open-formulieren/formio-builder#188

Changes

  • Upgraded formio-builder to enable soft required validation option in file components
  • Enabled the new softRequiredErrors component in the form designer
  • Added documentation on how to use these components

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (9c49379) to head (6dffdd6).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4755   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         746      746           
  Lines       25205    25207    +2     
  Branches     3320     3321    +1     
=======================================
+ Hits        24340    24342    +2     
  Misses        602      602           
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Mostly affects developers I suppose, since there's no way to select
this form definition later on anyway.
It contains the necessary components.
@sergei-maertens sergei-maertens force-pushed the feature/4546-soft-required-validation branch from ddef897 to 0708ed4 Compare October 16, 2024 14:49
@sergei-maertens sergei-maertens force-pushed the feature/4546-soft-required-validation branch from 0708ed4 to 6dffdd6 Compare October 16, 2024 14:50
@sergei-maertens sergei-maertens marked this pull request as ready for review October 16, 2024 14:51
Copy link
Contributor

@robinmolen robinmolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good 👍

@sergei-maertens sergei-maertens merged commit 57ffe50 into master Oct 17, 2024
33 of 37 checks passed
@sergei-maertens sergei-maertens deleted the feature/4546-soft-required-validation branch October 17, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "soft required" validation/hint to document uploads component
2 participants