Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4659] Fix default value for textfield #4738

Merged
merged 11 commits into from
Oct 16, 2024

Conversation

robinmolen
Copy link
Contributor

@robinmolen robinmolen commented Oct 7, 2024

Closes #4659

Changes

Ensuring that textfields have an empty string as default value

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen linked an issue Oct 7, 2024 that may be closed by this pull request
@robinmolen robinmolen changed the title Issue/4659 default value null for textfield [#4659] Fix default value for textfield Oct 7, 2024
@robinmolen robinmolen force-pushed the issue/4659-default-value-null-for-textfield branch 4 times, most recently from 5710b49 to 7d60db5 Compare October 10, 2024 08:36
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (224a896) to head (2669121).
Report is 90 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4738   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         746      746           
  Lines       25175    25216   +41     
  Branches     3310     3323   +13     
=======================================
+ Hits        24310    24350   +40     
- Misses        601      602    +1     
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinmolen robinmolen force-pushed the issue/4659-default-value-null-for-textfield branch 3 times, most recently from 1c2653e to 37bfc2f Compare October 14, 2024 08:57
@robinmolen robinmolen force-pushed the issue/4659-default-value-null-for-textfield branch 2 times, most recently from 316eda6 to e4cfdc7 Compare October 14, 2024 10:48
@robinmolen robinmolen force-pushed the issue/4659-default-value-null-for-textfield branch 2 times, most recently from da09ea8 to 7697b86 Compare October 15, 2024 14:19
@robinmolen robinmolen force-pushed the issue/4659-default-value-null-for-textfield branch from 7697b86 to f3b8af7 Compare October 15, 2024 15:01
@robinmolen robinmolen force-pushed the issue/4659-default-value-null-for-textfield branch from f3b8af7 to 2669121 Compare October 15, 2024 15:21
@sergei-maertens sergei-maertens merged commit ad7ead2 into master Oct 16, 2024
33 of 34 checks passed
@sergei-maertens sergei-maertens deleted the issue/4659-default-value-null-for-textfield branch October 16, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden components with "Multiple values" trigger validation
2 participants