-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4659] Fix default value for textfield #4738
Merged
sergei-maertens
merged 11 commits into
master
from
issue/4659-default-value-null-for-textfield
Oct 16, 2024
Merged
[#4659] Fix default value for textfield #4738
sergei-maertens
merged 11 commits into
master
from
issue/4659-default-value-null-for-textfield
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmolen
changed the title
Issue/4659 default value null for textfield
[#4659] Fix default value for textfield
Oct 7, 2024
robinmolen
force-pushed
the
issue/4659-default-value-null-for-textfield
branch
4 times, most recently
from
October 10, 2024 08:36
5710b49
to
7d60db5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4738 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 746 746
Lines 25175 25216 +41
Branches 3310 3323 +13
=======================================
+ Hits 24310 24350 +40
- Misses 601 602 +1
Partials 264 264 ☔ View full report in Codecov by Sentry. |
robinmolen
force-pushed
the
issue/4659-default-value-null-for-textfield
branch
3 times, most recently
from
October 14, 2024 08:57
1c2653e
to
37bfc2f
Compare
robinmolen
force-pushed
the
issue/4659-default-value-null-for-textfield
branch
2 times, most recently
from
October 14, 2024 10:48
316eda6
to
e4cfdc7
Compare
robinmolen
force-pushed
the
issue/4659-default-value-null-for-textfield
branch
2 times, most recently
from
October 15, 2024 14:19
da09ea8
to
7697b86
Compare
robinmolen
force-pushed
the
issue/4659-default-value-null-for-textfield
branch
from
October 15, 2024 15:01
7697b86
to
f3b8af7
Compare
robinmolen
force-pushed
the
issue/4659-default-value-null-for-textfield
branch
from
October 15, 2024 15:21
f3b8af7
to
2669121
Compare
sergei-maertens
approved these changes
Oct 16, 2024
sergei-maertens
deleted the
issue/4659-default-value-null-for-textfield
branch
October 16, 2024 13:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4659
Changes
Ensuring that textfields have an empty string as default value
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Commit hygiene