Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4516] Fix import of forms with Objects API registration backends without any group set #4522

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jul 12, 2024

Closes #4516

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@Viicos Viicos added the needs-backport Fix must be backported to stable release branch label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (ac6a7c2) to head (578d43f).
Report is 519 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4522   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         719      719           
  Lines       24089    24088    -1     
  Branches     2863     2866    +3     
=======================================
+ Hits        23263    23264    +1     
+ Misses        562      560    -2     
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge and backport tomorrow!

@sergei-maertens sergei-maertens merged commit 2bb96af into master Jul 18, 2024
32 checks passed
@sergei-maertens sergei-maertens deleted the issue/4516-import-crash branch July 18, 2024 08:23
sergei-maertens pushed a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import of legacy Objects API registration forms is not possible anymore
2 participants