[#3889] Improve timeline logs admin

[Viicos]

Fixes #3889

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.10%. Comparing base (cb2960c) to head (ae56b09).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4086   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files         730      730           
  Lines       23085    23130   +45     
  Branches     2698     2701    +3     
=======================================
+ Hits        22185    22230   +45     
  Misses        638      638           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sergei-maertens]

can't we just assert what is present?

options = {value for value, *_ in html_form.fields.get("action")[0].options}
self.assertEqual(options, {"_export"})  # or whatever the relevant value is

[Viicos]

This test is originally to assert that you can't delete records. With your assertion suggestion the test would break whenever a new action gets added? Probably not going happen anyway 🤔

[sergei-maertens]

yeah and if the value of the action option in django changes, your version will break and be harder to debug, while this proposed change is a lot more readable and obvious

the previous test assertion worked because it checked that the action dropdown as a whole is absent :)

[Viicos]

Well same can happen if django-import-export changes the name of the action as well 😄 but this would be a straightforward test update anyway