Handle map components (point coordinates) consistently. #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I v2 handler By looking at the formio component defined for the variable, we can figure out which processing is needed to make it fit the Objects API requirements, such as converting raw coordinates into a GeoJSON Point object.
sergei-maertens
commented
Mar 22, 2024
sergei-maertens
commented
Mar 22, 2024
sergei-maertens
commented
Mar 22, 2024
Comment on lines
+214
to
+216
| with ( | ||
| get_documents_client() as documents_client, | ||
| save_and_raise(registration_data), |
There was a problem hiding this comment.
black had opinions 🤷
There was a problem hiding this comment.
Interesting, are you running under Python 3.10?
There was a problem hiding this comment.
Yes, 3.10.13. Are you not?
There was a problem hiding this comment.
3.10.13 as well, sometimes the Python version used to run black can alter the formatting, but in this case I have no idea why 🤷
Viicos
reviewed
Mar 22, 2024
src/openforms/registrations/contrib/objects_api/submission_registration.py
Show resolved
Hide resolved
src/openforms/registrations/contrib/objects_api/tests/test_backend_v2.py
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4048 +/- ##
==========================================
- Coverage 96.07% 96.07% -0.01%
==========================================
Files 728 728
Lines 22877 22893 +16
Branches 2656 2659 +3
==========================================
+ Hits 21980 21995 +15
Misses 636 636
- Partials 261 262 +1 ☔ View full report in Codecov by Sentry. |
Viicos
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4038