Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle object types with no geometry allowed #4046

Closed
wants to merge 1 commit into from

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Mar 22, 2024

I will probably close this PR at some point, as I think it's better to handle it as sergei said:

instead of handling the mapping as everything inside data and special casing geometry, can't we just implicitly add the data path prefix to everything so then you get a list of targets:

  • geometry
  • data.firstName
  • data.lastName
  • data.country
    but the end user never needs to worry about the data. prefix
    (of course keeping the types in mind here)
    the reason I'm asking this is also because you can have a second map in the form which goes to data.additionalGeometry, and that thing also needs to be pre-processed to produce geo-json

With this solution in my mind, we would just have to remove geometry if allowGeometry is False in the objecttypes API

@Viicos
Copy link
Contributor Author

Viicos commented Apr 3, 2024

#4102 is an attempt to do so, but I'm closing it as it turns out the solution is to hard to implement

@joeribekker
Copy link
Contributor

joeribekker commented Apr 8, 2024

Refinement: @Viicos please make a ticket for this with triage label

@joeribekker
Copy link
Contributor

Refinement: Closing since its a very edge case and no stakeholder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants