Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3688] Remove productaanvraagType for v2 options #4043

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Mar 22, 2024

Part of #3688

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (75c3268) to head (d8be6b9).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4043   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         728      728           
  Lines       22867    22877   +10     
  Branches     2654     2656    +2     
=======================================
+ Hits        21970    21980   +10     
  Misses        636      636           
  Partials      261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we missed only the removal of productaanvraagType in the definition (V2ConfigFields.propTypes)

@sergei-maertens sergei-maertens force-pushed the feature/3688-productaanvraag-type-v2 branch from d8be6b9 to 7e39fe9 Compare March 22, 2024 15:39
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Processed the feedback (proptype removal)

@sergei-maertens sergei-maertens merged commit 2d19697 into master Mar 22, 2024
10 of 15 checks passed
@sergei-maertens sergei-maertens deleted the feature/3688-productaanvraag-type-v2 branch March 22, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants