Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporting a form from 'test' and importing on 'acceptance' leads to invalid URLs to informatieobjecttypes #4330

Open
2 tasks
alextreme opened this issue May 27, 2024 · 4 comments · May be fixed by #4532
Open
2 tasks

Exporting a form from 'test' and importing on 'acceptance' leads to invalid URLs to informatieobjecttypes #4330

alextreme opened this issue May 27, 2024 · 4 comments · May be fixed by #4532
Labels
discuss enhancement owner: den-haag owner: utrecht topic: form import/export topic: otap

Comments

@alextreme
Copy link
Contributor

alextreme commented May 27, 2024 •
edited by joeribekker
Loading

Thema / Theme

Admin

Omschrijving / Description

Discussed with Laurens. When exporting a form in OF and importing it in another environment, the URL references to informatieobjecttypes still point to the test environment. This leads to forms that don't work after importing them.

(I'm limiting the scope of this issue on purpose to only IOTs, as certain OF DH forms have dozens of IOT references)

There are a number of ways how we can improve this, some suggestions:

  • Ensuring that when importing a form, that the admin can see and modify the imported IOT URLs
  • Ensuring that there's a page to check (GET) the IOTs configured for the form and show the URLs
  • Ability to configure test/acc/prod configuration within the form (suggestion Laurens)

This has been discussed between Laurens and Joeri earlier, I'm attempting to broaden the discussion and see what's possible with a more limited scope

Tasks

  • Make sure import/export uses natural keys (problem identified: we store primary keys for object api/zgw api groups, service fetch)
  • MORE
@alextreme alextreme added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels May 27, 2024
@sergei-maertens
Copy link
Member

we should store the omschrijving/identificatie instead of the full URLs, so that the latest version of that object can be resolved dynamically. The same approach is planned for zaaktype too.

@joeribekker
Copy link
Contributor

Refinement: I think this issue will be part of workpackage that includes NEVER to save URLs but only the unique attributes, and lookup the URL when needed. This workpackage will be incoming.. in 2.8 I think.

@joeribekker joeribekker added owner: den-haag topic: otap and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Jun 10, 2024
@joeribekker joeribekker added this to the Release 2.8.0 milestone Jun 10, 2024
@joeribekker
Copy link
Contributor

Related: #4267

@joeribekker
Copy link
Contributor

This ticket is about import and export. The work Viicos is doing is essential for this.

@joeribekker joeribekker removed this from the Release 2.8.0 milestone Jul 15, 2024
@Viicos Viicos mentioned this issue Jul 17, 2024
Merged
9 tasks
Viicos added a commit that referenced this issue Jul 17, 2024
@Viicos
[#4330] Add unique constraint to group configs names
89cdff6
@Viicos Viicos linked a pull request Jul 17, 2024 that will close this issue
Draft
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss enhancement owner: den-haag owner: utrecht topic: form import/export topic: otap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4330] Add unique constraint to group configs names open-formulieren/open-forms
3 participants
@joeribekker @alextreme @sergei-maertens