Skip to content

Commit

Permalink
🔥 [#4000] Delete the 'save and add another' button
Browse files Browse the repository at this point in the history
Checked that this was not used in other screens - all other SubmitRow
usage explicitly specifies the children so this button is effectively
unused.
  • Loading branch information
sergei-maertens committed Mar 20, 2024
1 parent 77602e1 commit 06adf36
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 23 deletions.
11 changes: 1 addition & 10 deletions src/openforms/js/components/admin/forms/ActionButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,6 @@ const SubmitAction = props => {
return <ActionButton name="_save" text={btnText} {...props} />;
};

const AddAnotherAction = props => {
const intl = useIntl();
const btnText = intl.formatMessage({
description: 'Admin save and add another submit button',
defaultMessage: 'Save and add another',
});
return <ActionButton name="_addanother" text={btnText} {...props} />;
};

const ContinueEditingAction = props => {
const intl = useIntl();
const btnText = intl.formatMessage({
Expand All @@ -43,4 +34,4 @@ const ContinueEditingAction = props => {
};

export default ActionButton;
export {ActionButton, SubmitAction, AddAnotherAction, ContinueEditingAction};
export {ActionButton, SubmitAction, ContinueEditingAction};
6 changes: 1 addition & 5 deletions src/openforms/js/components/admin/forms/ActionButton.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {ArgTypes, Canvas, Meta} from '@storybook/addon-docs';

import {ActionButton, AddAnotherAction, ContinueEditingAction, SubmitAction} from './ActionButton';
import {ActionButton, ContinueEditingAction, SubmitAction} from './ActionButton';
import * as ActionButtonStories from './ActionButton.stories';

<Meta of={ActionButtonStories} />
Expand All @@ -21,10 +21,6 @@ The default Django admin action buttons

<Canvas of={ActionButtonStories.SubmitActionStory} />

### Save and add another

<Canvas of={ActionButtonStories.AddAnotherActionStory} />

### Save and edit

<Canvas of={ActionButtonStories.ContinueEditingActionStory} />
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {ActionButton, AddAnotherAction, ContinueEditingAction, SubmitAction} from './ActionButton';
import {ActionButton, ContinueEditingAction, SubmitAction} from './ActionButton';

export default {
title: 'Admin/Django/ActionButton',
Expand All @@ -19,11 +19,6 @@ export const SubmitActionStory = {
render: () => <SubmitAction />,
};

export const AddAnotherActionStory = {
name: 'AddAnotherAction',
render: () => <AddAnotherAction />,
};

export const ContinueEditingActionStory = {
name: 'ContinueEditingAction',
render: () => <ContinueEditingAction />,
Expand Down
3 changes: 1 addition & 2 deletions src/openforms/js/components/admin/forms/SubmitRow.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import PropTypes from 'prop-types';
import React from 'react';

import {AddAnotherAction, ContinueEditingAction, SubmitAction} from './ActionButton';
import {ContinueEditingAction, SubmitAction} from './ActionButton';

const SubmitRow = ({
onSubmit,
Expand All @@ -25,7 +25,6 @@ const SubmitRow = ({
{children ?? (
<>
<SubmitAction className={isDefault ? 'default' : ''} onClick={onSubmitClick} />
<AddAnotherAction onClick={onSubmitClick} />
<ContinueEditingAction onClick={onSubmitClick} />
</>
)}
Expand Down

0 comments on commit 06adf36

Please sign in to comment.