Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flagd CRD with ingress support #633

Merged
merged 46 commits into from
May 15, 2024
Merged

feat: add flagd CRD with ingress support #633

merged 46 commits into from
May 15, 2024

Conversation

bacherfl
Copy link
Contributor

@bacherfl bacherfl commented May 7, 2024 •
edited
Loading

Closes #615

The PR adds a new Flagd CRD which can be used to deploy an instance of flagd, together with a matching service and ingress

bacherfl added 13 commits May 7, 2024 15:43
@bacherfl
feat: add flagd crd and controller to deploy flagd
854d484 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
extract deployment reconciler into separate component
0dda209 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
implement flagd deployment/service/ingress creation
cdc2658 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
update crd definition
7c7cd90 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix creation of resources
434c2bd 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix creation of resources
3e12f20 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
add unit tests for controller
e850192 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
add mock
841454d 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
add unit tests
15922b1 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
add unit tests; support flagd grpc port
2d04e04 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
clean up types, add unit tests
bfa890b 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
clean up types, add unit tests
f5f580a 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix linting
4fd0820 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl force-pushed the feat/615/flagd-crd2 branch from f348d57 to 4fd0820 Compare May 7, 2024 13:43
bacherfl added 16 commits May 8, 2024 07:18
@bacherfl
Merge remote-tracking branch 'upstream/main' into feat/615/flagd-crd2
a1c47cc 
# Conflicts:
#	apis/core/v1beta1/zz_generated.deepcopy.go
#	go.mod
#	main.go
@bacherfl
adapt to changes from main branch
8e7e48f 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
update go deps
b2b4bbd 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
update crd docs
efedc19 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
go mod tidy
b28788b 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix linting
542ce1d 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix linting
d6841cc 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
create ingress only if enabled
0539105 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
refer to feature flag source in same namespace
2ee275d 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
refer to feature flag source in same namespace
08cc258 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
properties for customizing paths and pathtype for ingress rules
1f9b5e2 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
add kuttl tests
bc45b9a 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
fix unit tests
66c30e0 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
add description for new helm values
28651e8 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
add helm value to enable/disable the flagd resource support
75512ec 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
do not grant additional permissions if flagd resource is disabled
5c2bae2 
Signed-off-by: Florian Bacher <[email protected]>
@toddbaert toddbaert self-requested a review May 13, 2024 15:43
toddbaert
toddbaert reviewed May 13, 2024
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, but I have some confusion with this, and I think we need a very small addition covering this new feature in docs.

@toddbaert toddbaert requested a review from Kavindu-Dodan May 13, 2024 16:07
Kavindu-Dodan
Kavindu-Dodan reviewed May 13, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
bacherfl added 6 commits May 14, 2024 07:29
@bacherfl
adapt to PR review comments
8291d51 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
Merge remote-tracking branch 'upstream/main' into feat/615/flagd-crd2
a7d08bf 
# Conflicts:
#	Makefile
@bacherfl
remove replace directive
2d2ae2a 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
update CRD docs
ba7722a 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
update helm docs
49bc4a0 
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl
init workspace before linting
b1aed49 
Signed-off-by: Florian Bacher <[email protected]>
Kavindu-Dodan
Kavindu-Dodan approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bacherfl for this feature and clarifications 🙌

@toddbaert
Copy link
Member

Thanks @bacherfl

@bacherfl bacherfl merged commit b0b99a7 into open-feature:main May 15, 2024
15 checks passed
@bacherfl bacherfl deleted the feat/615/flagd-crd2 branch May 15, 2024 05:18
This was referenced May 15, 2024
Merged
Merged
@beeme1mr beeme1mr mentioned this pull request May 21, 2024
Closed
@lukas-reining lukas-reining mentioned this pull request Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@toddbaert toddbaert toddbaert approved these changes

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how to leverage OFO for workloads external to k8s , say a web frontend or something running outside k8s
4 participants
@bacherfl @toddbaert @Kavindu-Dodan @odubajDT