Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up unused API code after moving to v1beta1 #543

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 15, 2023

This PR

  • removes conversion and and validation webhook logic
  • removes struct functions of v1alpha* API definitions
  • removes unused tests
  • enables api unit tests to be executed with the operator unit tests

Related Issues

Fixes #532

Depends on: #539

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #543 (be8bac3) into main (d234410) will increase coverage by 2.37%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   81.86%   84.23%   +2.37%     
==========================================
  Files           7       10       +3     
  Lines         805     1015     +210     
==========================================
+ Hits          659      855     +196     
- Misses        118      130      +12     
- Partials       28       30       +2     

see 3 files with indirect coverage changes

Flag Coverage Δ
unit-tests 84.23% <ø> (+2.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT force-pushed the feat/532/cleanup-api branch from 4b082ee to 40d520d Compare November 15, 2023 14:46
@odubajDT odubajDT closed this Nov 16, 2023
@odubajDT odubajDT force-pushed the feat/532/cleanup-api branch from 40d520d to d234410 Compare November 16, 2023 14:28
@odubajDT odubajDT reopened this Nov 16, 2023
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT force-pushed the feat/532/cleanup-api branch from 382d15b to be8bac3 Compare November 16, 2023 15:08
@odubajDT odubajDT marked this pull request as ready for review November 16, 2023 15:11
@odubajDT odubajDT requested a review from a team as a code owner November 16, 2023 15:11
@odubajDT odubajDT merged commit 1287b07 into open-feature:main Nov 17, 2023
13 checks passed
This was referenced Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up leftover logic in v1alpha* APIs
3 participants