Skip to content

Commit

Permalink
review suggestions
Browse files Browse the repository at this point in the history
Signed-off-by: Skye Gill <[email protected]>
  • Loading branch information
skyerus committed Mar 21, 2023
1 parent 6a1306c commit a68d058
Showing 1 changed file with 20 additions and 1 deletion.
21 changes: 20 additions & 1 deletion OFEP-ofo-flagd-service.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,23 @@ The driving force behind this is to simplify the deployment of flagd for use by
## Proposal

Introduce a FlagdService custom resource definition (CRD) and controller.
The controller uses the configuration defined within the custom resource (CR) to create a Service and a Deployment of flagd (backed by the Service). This is a common deployment pattern permitting access by any component that routes to the created Service (e.g. Ingress/Load Balancer).
The controller uses the configuration defined within the custom resource (CR) to create a Service and a Deployment of flagd (backed by the Service) in the configured namespace. This is a common deployment pattern permitting access by any component that routes to the created Service (e.g. Ingress/Load Balancer). OFO already manages the [sidecar deployment pattern](https://learn.microsoft.com/en-us/azure/architecture/patterns/sidecar) to achieve the goal of internally routable flagd. In contrast, the described FlagdService pattern permits externally routable flagd.

### RBAC

OFO already has RBAC to Deployments but not Services so the following is required.

```
- apiGroups:
- ""
resources:
- services
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
```

0 comments on commit a68d058

Please sign in to comment.