Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support azure blob sync #1428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wilson-matthew
Copy link
Contributor

This PR

  • adds support for Azure Blob Storage sync

How to test

  • create an Azure Storage Account and a container with a flags definition file inside
  • set AZURE_STORAGE_ACCOUNT env var to the name of the storage account
  • set AZURE_STORAGE_KEY env var to the access key of the storage account, or use another authentication method: https://pkg.go.dev/gocloud.dev/blob/azureblob#hdr-URLs
  • start flagd with the --uri flag set to azblob://my-container/my-flags.json

@wilson-matthew wilson-matthew requested a review from a team as a code owner October 21, 2024 15:55
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 21, 2024
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit 9e98688
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/67167daa87829100086c15d7
😎 Deploy Preview https://deploy-preview-1428--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Matthew Wilson <[email protected]>
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd like to test it out manually before giving a final approval, but it looks good so far. Also, nice job catching all those doc inconsistencies.

@beeme1mr
Copy link
Member

Hey @wilson-matthew, I'm new to Azure, so please bear with me. I tried to test using a SAS token but ran into a 403. The environment variable I set was AZURE_STORAGE_SAS_TOKEN, which appears to be supported by the blob library. Do you have any idea what's happening, or should I try a different auth mechanism?

@wilson-matthew
Copy link
Contributor Author

Hey @beeme1mr, I just tested using a SAS token with the AZURE_STORAGE_SAS_TOKEN environment variable and it worked okay for me. What settings did you use when generating the SAS token - I wonder if it didn’t have the correct permissions? You could try the AZURE_STORAGE_KEY auth mechanism as that is unlikely to have a permissions issue.

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it working, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants