feat: dummy sync server #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/grpc-sync-stub
branch
from
064b6dc to
6dd7ad1
Compare
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
sync/Dockerfile
Outdated
| @@ -0,0 +1,8 @@ | |||
| FROM busybox:1.36 | |||
|
|
|||
| COPY sync/bin/* . | |||
There was a problem hiding this comment.
Personally, I prefer a standalone docker file. here this depends on the MakeFile 🤔
Can we first build the binary and then extract that from a staged docker build ?
There was a problem hiding this comment.
Ya good call. I'll make that change
There was a problem hiding this comment.
I've done this: 841449b
There was a problem hiding this comment.
I am happy with the dockerfile. Could you also check ci.yaml 1
Footnotes
There was a problem hiding this comment.
I've removed the go building from the ci.
|
Overal looks good 👍 |
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Kavindu-Dodan
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stub for mocking a sync server.
You can test it easily like this:
go run main.go -f ../flags1.json -f ../flags2.jsonthen:
grpcurl -import-path '/home/{user}/Downloads' -proto sync.proto -plaintext localhost:9090 sync.v1.FlagSyncService/FetchAllFlags(assuming you have
sync.protoin your downloads)You can also do
sync.v1.FlagSyncService/SyncFlagswhich will open a stream that sends the merged payload anytime you change one of the files.