Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove sync server (#114) #153

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,17 +43,3 @@ jobs:
context: .
file: flagd/Dockerfile.unstable
push: false

- name: Build sync-testbed Docker image
uses: docker/build-push-action@v6
with:
context: .
file: sync/Dockerfile
push: false

- name: Build sync-testbed-unstable Docker image
uses: docker/build-push-action@v6
with:
context: .
file: sync/Dockerfile.unstable
push: false
26 changes: 7 additions & 19 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ jobs:
tags: |
${{ env.REGISTRY }}/open-feature/${{ env.FLAGD_IMAGE_NAME }}:${{ needs.release-please.outputs.release_tag_name }}
${{ env.REGISTRY }}/open-feature/${{ env.FLAGD_IMAGE_NAME }}:latest
# For backwards compatibility remove as soon as nobody is using sync server anymore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

${{ env.REGISTRY }}/open-feature/${{ env.SYNC_IMAGE_NAME }}:${{ needs.release-please.outputs.release_tag_name }}
${{ env.REGISTRY }}/open-feature/${{ env.SYNC_IMAGE_NAME }}:latest

- name: Build and push flagd-testbed-unstable Docker image
uses: docker/build-push-action@v6
Expand All @@ -70,24 +73,9 @@ jobs:
push: true
tags: |
${{ env.REGISTRY }}/open-feature/${{ env.FLAGD_IMAGE_NAME }}-unstable:${{ needs.release-please.outputs.release_tag_name }}
${{ env.REGISTRY }}/open-feature/${{ env.FLAGD_IMAGE_NAME }}-unstable:latest

- name: Build and push sync-testbed Docker image
uses: docker/build-push-action@v6
with:
context: .
file: sync/Dockerfile
push: true
tags: |
${{ env.REGISTRY }}/open-feature/${{ env.FLAGD_IMAGE_NAME }}-unstable:latest
# For backwards compatibility remove as soon as nobody is using sync server anymore
${{ env.REGISTRY }}/open-feature/${{ env.SYNC_IMAGE_NAME }}:${{ needs.release-please.outputs.release_tag_name }}
${{ env.REGISTRY }}/open-feature/${{ env.SYNC_IMAGE_NAME }}:latest

- name: Build and push sync-testbed-unstable Docker image
uses: docker/build-push-action@v6
with:
context: .
file: sync/Dockerfile.unstable
push: true
tags: |
${{ env.REGISTRY }}/open-feature/${{ env.SYNC_IMAGE_NAME }}-unstable:${{ needs.release-please.outputs.release_tag_name }}
${{ env.REGISTRY }}/open-feature/${{ env.SYNC_IMAGE_NAME }}-unstable:latest


6 changes: 0 additions & 6 deletions Makefile

This file was deleted.

7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,6 @@ The _flagd-testbed_ container is a docker image built on flagd, which essentiall

See the [flagd docs](https://flagd.dev/) for more information on flagd.

## sync-testbed container

The _sync_-testbed_ container is a docker image built on conforming to the sync.proto - a grpc which flagd or flagd in-process providers can use as a sync-source.
It features an identical set of flags to the [flagd-testbed container](#flagd-testbed-container)

For details on the sync-testbed, see [sync/README.me](sync/README.md)

## Gherkin test suite

The [gherkin/](gherkin/) dir includes a set of [_gherkin_](https://cucumber.io/docs/gherkin/) tests that define expected behavior associated with the configurations defined in the flagd-testbed (see [flags/](flags/)).
Expand Down
22 changes: 0 additions & 22 deletions sync/Dockerfile

This file was deleted.

17 changes: 0 additions & 17 deletions sync/Dockerfile.unstable

This file was deleted.

91 changes: 0 additions & 91 deletions sync/README.md

This file was deleted.

19 changes: 0 additions & 19 deletions sync/go.mod

This file was deleted.

Loading