Add Parameter support in DataThreads

open-ephys · Sep 22, 2023 · c13e1dd · c13e1dd
1 parent c87e6f6
commit c13e1dd
Show file tree

Hide file tree

Showing 6 changed files with 36 additions and 2 deletions.
diff --git a/Source/Processors/DataThreads/DataThread.h b/Source/Processors/DataThreads/DataThread.h
@@ -88,6 +88,9 @@ class PLUGIN_API DataThread : public Thread
     // VIRTUAL METHODS
     // ---------------------
 
+    /**Create & register parameters for the DataThread */
+    virtual void registerParameters() {};
+
     /** Called when the chain updates, to add, remove or resize the sourceBuffers' DataBuffers as needed*/
     virtual void resizeBuffers() { }
 
@@ -104,6 +107,9 @@ class PLUGIN_API DataThread : public Thread
     /** Allows the DataThread to set its default state, depending on whether the signal chain is loading */
     virtual void initialize(bool signalChainIsLoading) { }
 
+    /** Called when a parameter value is updated, to allow plugin-specific responses */
+    virtual void parameterValueChanged(Parameter*) { }
+
     // ---------------------
     // NON-VIRTUAL METHODS
     // ---------------------

diff --git a/Source/Processors/GenericProcessor/GenericProcessor.cpp b/Source/Processors/GenericProcessor/GenericProcessor.cpp
@@ -960,7 +960,10 @@ void GenericProcessor::update()
             messageChannel->addProcessor(this);
             messageChannel->setDataStream(AccessClass::getMessageCenter()->getMessageStream());
 
-            if (!isSource())
+            // If Source call updateSettings immediately
+            if (isSource())
+                updateSettings();
+            else
                 isEnabled = false;
 
             LOGD(getNodeId(), " connected to Message Center");
@@ -1140,7 +1143,7 @@ void GenericProcessor::update()
 
     LOGG("    Copied parameters in ", MS_FROM_START, " milliseconds");
 
-    if (!isMerger())
+    if (!isMerger() && !isSource())
         updateSettings(); // allow processors to change custom settings,
                           // including creation of streams / channels and
                           // setting isEnabled variable

diff --git a/Source/Processors/Parameter/ParameterEditor.cpp b/Source/Processors/Parameter/ParameterEditor.cpp
@@ -115,6 +115,8 @@ void TextBoxParameterEditor::labelTextChanged(Label* label)
 {
     if(param->getType() == Parameter::FLOAT_PARAM)
         param->setNextValue(label->getText().getFloatValue());
+    else if(param->getType() == Parameter::INT_PARAM)
+        param->setNextValue(label->getText().getIntValue());
     else
         param->setNextValue(label->getText());
 }

diff --git a/Source/Processors/ProcessorGraph/ProcessorGraph.cpp b/Source/Processors/ProcessorGraph/ProcessorGraph.cpp
@@ -820,9 +820,15 @@ void ProcessorGraph::restoreParameters()
         }
     }
 
+    // Create message center event channel (necessary for DataThreads)
+    getMessageCenter()->addSpecialProcessorChannels();
+
     // load source node parameters
     for (auto p : rootNodes)
     {
+        if(p->getPluginType() == Plugin::Type::DATA_THREAD)
+            p->update();
+
         p->loadFromXml();
     }
 

diff --git a/Source/Processors/SourceNode/SourceNode.cpp b/Source/Processors/SourceNode/SourceNode.cpp
@@ -104,6 +104,11 @@ void SourceNode::initialize(bool signalChainIsLoading)
     dataThread->initialize(signalChainIsLoading);
 }
 
+void SourceNode::registerParameters()
+{
+    dataThread->registerParameters();
+}
+
 
 void SourceNode::requestSignalChainUpdate()
 {
@@ -147,6 +152,12 @@ void SourceNode::updateSettings()
 }
 
 
+void SourceNode::parameterValueChanged(Parameter* parameter)
+{
+    dataThread->parameterValueChanged(parameter);
+}
+
+
 float SourceNode::getSampleRate(int streamId) const
 {
     if (dataThread != nullptr)

diff --git a/Source/Processors/SourceNode/SourceNode.h b/Source/Processors/SourceNode/SourceNode.h
@@ -50,6 +50,9 @@ class PLUGIN_API SourceNode : public GenericProcessor
     /* Create a custom editor. */
     AudioProcessorEditor* createEditor() override;
 
+    /** Registers the parameters for a given processor */
+    void registerParameters() override;
+
     /* Copies samples from the DataThread's DataBuffer into the GUI's processing buffers. */
     void process (AudioBuffer<float>& buffer) override;
 
@@ -98,6 +101,9 @@ class PLUGIN_API SourceNode : public GenericProcessor
 
     /** Passes initialize command to the DataThread*/
     void initialize(bool signalChainIsLoading) override;
+
+    /** Called when a parameter value is updated, to allow plugin-specific responses*/
+    void parameterValueChanged(Parameter*) override;
 
 private: