Discard parameter unodable action if previous value is restored

open-ephys · Oct 18, 2024 · 0ee18c9 · 0ee18c9
1 parent 8d08025
commit 0ee18c9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/Source/Processors/GenericProcessor/GenericProcessor.cpp b/Source/Processors/GenericProcessor/GenericProcessor.cpp
@@ -557,6 +557,7 @@ void GenericProcessor::setParameter (int parameterIndex, float newValue)
     if (currentParameter != nullptr)
     {
         currentParameter->updateValue();
+        currentParameter->logValueChange();
         parameterValueChanged (currentParameter);
     }
 }

diff --git a/Source/Processors/Parameter/Parameter.cpp b/Source/Processors/Parameter/Parameter.cpp
@@ -229,17 +229,18 @@ bool Parameter::ChangeValue::perform()
 {
     Parameter* p = Parameter::parameterMap[key];
 
-    if (! p->isEnabled())
+    if (! p->isEnabled() || p->currentValue == newValue)
         return false;
 
     p->newValue = newValue;
     p->getOwner()->parameterChangeRequest (p);
 
     p->valueChanged();
 
-    p->logValueChange();
-
-    return true;
+    if (p->currentValue == p->previousValue)
+        return false;
+    else
+        return true;
 }
 
 bool Parameter::ChangeValue::undo()
@@ -251,7 +252,7 @@ bool Parameter::ChangeValue::undo()
 
     p->valueChanged();
 
-    p->logValueChange();
+    //p->logValueChange();
 
     return true;
 }
@@ -1338,7 +1339,6 @@ void SelectedStreamParameter::setStreamNames (Array<String> streamNames_)
     {
         getOwner()->parameterChangeRequest (this);
         valueChanged();
-        logValueChange();
     }
 }
 
@@ -1448,8 +1448,6 @@ bool TimeParameter::ChangeValue::perform()
 
     p->valueChanged();
 
-    p->logValueChange();
-
     return true;
 }
 
@@ -1463,8 +1461,6 @@ bool TimeParameter::ChangeValue::undo()
 
     p->valueChanged();
 
-    p->logValueChange();
-
     return true;
 }
 

diff --git a/Source/Processors/Parameter/Parameter.h b/Source/Processors/Parameter/Parameter.h
@@ -337,7 +337,7 @@ class PLUGIN_API Parameter
     void valueChanged();
 
     /** Makes it possible to undo value changes */
-    class ChangeValue : public UndoableAction
+    class PLUGIN_API ChangeValue : public UndoableAction
     {
     public:
         /** Constructor */