Rhs2116 step size algorithm now accounts for requested amplitude #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When calculating the error to find the optimum step size, the algorithm now utilizes the requested amplitude so that in the case when no stimuli are present, the error is correctly modified for each step size and the appropriate size is chosen for the requested amplitude
jonnew
reviewed
Jan 2, 2025
- From review comments, simplified the error calculation by moving ternary operators inside the CalculateError method - Additionally, step size index now accounts for multiple step sizes with the same error, preferentially choosing the step size that is closest to the original step size to minimize changes in absolute amplitude
jonnew
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating the error to find the optimum step size, the algorithm now utilizes the requested amplitude so that in the case when no stimuli are present, the error is correctly modified for each step size and the appropriate size is chosen for the requested amplitude