Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow individual parameters to be changed #348

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Allow individual parameters to be changed #348

merged 1 commit into from
Oct 28, 2024

Conversation

bparks13
Copy link
Member

Instead of requiring all parameters to be filled out and then subsequently written to a channel, this update now allows only those parameters that are filled in to be applied to a channel or channels.

For example, instead of having to fill out all timings and amplitudes, if the pulse width is the only parameter that needs to be updated, the pulse width is the only variable that is filled in when Apply is pressed.

Added additional checks if the pulse is biphasic symmetric to ensure consistency.

@bparks13 bparks13 added this to the 0.4.1 milestone Oct 22, 2024
@bparks13 bparks13 requested a review from jonnew October 22, 2024 21:10
@jonnew
Copy link
Member

jonnew commented Oct 25, 2024

This looks really good. I like the behavior a lot. The only critique I have is that the plot zoom resets when parameters are changed. The reason this is a bit annoying is because for a sequence I'm zoomed in to the portion of the waveform that I want to change. When I go edit e.g. an amplitude parameter and expect to see the at change reflected in the waveform, the view resizes and I have manually zoom in again to see if my change had the indented effect.

If there is a way to save the zoom state and reapply when parameters are changed, I would like that. Otherwise, this looks very good.

@bparks13
Copy link
Member Author

@jonnew I have created a new issue regarding saving the zoom state (#349), feel free to add any more thoughts to the issue. For now, I have set it as the 0.5.0 milestone, but we can push for it to be 0.4.1 if we fully define the problem quickly.

There is a very related issue (#313) that can also be fleshed out at the same time related to resizing dialogs.

@jonnew jonnew merged commit 4d7d712 into main Oct 28, 2024
7 checks passed
@jonnew jonnew deleted the issue-344 branch October 28, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rhs2116 Stimulus Sequence Dialog - Change individual parameters across all channels
2 participants