Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MiniCam frame rate #22

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix MiniCam frame rate #22

merged 2 commits into from
Nov 6, 2024

Conversation

jonnew
Copy link
Member

@jonnew jonnew commented Nov 4, 2024

@jonnew
Fix MiniCam frame rate
1bb46ff 
- The frame rate settings, copied for the Qt software, were completely non functional
@jonnew jonnew requested a review from bparks13 November 4, 2024 18:57
@jonnew
Copy link
Member Author

jonnew commented Nov 4, 2024

@bparks13 can you review, merge, create package and push to nuget

bparks13
bparks13 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@bparks13 bparks13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. There are a few warnings issued for public methods / classes that don't have any XML comments, but that can be fixed in another PR.

@bparks13 bparks13 merged commit 696040f into main Nov 6, 2024
8 checks passed
@bparks13 bparks13 deleted the issue-21 branch November 6, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparks13 bparks13 bparks13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue setting frame rate for MiniCam
2 participants
@jonnew @bparks13