SerialCommutator now manages its own serial port #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonnew
commented
Oct 30, 2024
jonnew
commented
- This is an attempt at getting around a possible issue with Bonsai's serial port libary implementation which is failing on some machines.
- Not sure if it will fix anything
- SerialCommutator is now used in AutoCommuator
- Fixes AutoCommutator node can hang in some machines #8
- This is an attempt at getting around a possible issue with Bonsai's serial port libary implementation which is failing on some machines. - Not sure if it will fix anything - SerialCommutator is now used in AutoCommuator
- I forgot to put a workflow output on AutoCommutator so that the user can see the commands being sent - Remove a bunch of unessesary packages from Bonsai.config
- They dont have an effect on motion. - This has now been tested in hardware and works well.
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.