Skip to content

Commit

Permalink
Merge pull request #14 from open-ephys/minor-updates
Browse files Browse the repository at this point in the history
Bump version to 0.1.1
  • Loading branch information
bparks13 authored Aug 28, 2024
2 parents 4f90c29 + cd3fc69 commit 4b87cbc
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<PackageLicenseFile>LICENSE</PackageLicenseFile>
<UseArtifactsOutput>true</UseArtifactsOutput>
<PackageIcon>icon.png</PackageIcon>
<VersionPrefix>0.1.0</VersionPrefix>
<VersionPrefix>0.1.1</VersionPrefix>
<VersionSuffix></VersionSuffix>
<LangVersion>10.0</LangVersion>
<Features>strict</Features>
Expand Down
5 changes: 3 additions & 2 deletions OpenEphys.ProbeInterface.NET/Probe.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public class Probe
/// </summary>
[XmlIgnore]
[JsonProperty("ndim", Required = Required.Always)]
public ProbeNdim NumDimensions { get; protected set; }
public ProbeNdim NumDimensions { get; protected set; }

/// <summary>
/// Gets the <see cref="ProbeSiUnits"/> to use while plotting the <see cref="Probe"/>.
Expand Down Expand Up @@ -149,7 +149,7 @@ public Probe(ProbeNdim ndim, ProbeSiUnits si_units, ProbeAnnotations annotations
/// Copy constructor given an existing <see cref="Probe"/> object.
/// </summary>
/// <param name="probe">Existing <see cref="Probe"/> object to be copied.</param>
protected Probe(Probe probe)
public Probe(Probe probe)

This comment has been minimized.

Copy link
@jonnew

jonnew Aug 29, 2024

Member

@bparks13 This constitutes a minor revision: https://semver.org/#spec-item-7

{
NumDimensions = probe.NumDimensions;
SiUnits = probe.SiUnits;
Expand Down Expand Up @@ -324,6 +324,7 @@ public Contact GetContact(int index)
/// <summary>
/// Gets the number of contacts within this <see cref="Probe"/>.
/// </summary>
[JsonIgnore]
public int NumberOfContacts => ContactPositions.Length;
}
}
1 change: 1 addition & 0 deletions OpenEphys.ProbeInterface.NET/ProbeGroup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ protected ProbeGroup(ProbeGroup probeGroup)
/// <summary>
/// Gets the number of contacts across all <see cref="Probe"/> objects.
/// </summary>
[JsonIgnore]
public int NumberOfContacts => Probes.Aggregate(0, (total, next) => total + next.NumberOfContacts);

/// <summary>
Expand Down

0 comments on commit 4b87cbc

Please sign in to comment.