You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have noticed the TransmitterPdu class extracts the RadioID field (ref) once inside the header field (see RadioCommsHeader class), and again separately in the radioNumber field. this causes an unnecessary shift of unmarshalling by 2 bytes. Removing it from the RadioCommsHeader class fixes the problem, but so does commenting out the local field to the TransmitterPdu class, and redirecting all calls to get/set of the RadioID to the embedded RadioCommsHeader instance's field. I'm not sure which way you want to go.
Let me know if you're the best POC, or if there's a preferred approach to raising these issues.
The text was updated successfully, but these errors were encountered:
Hi again Don @brutzman,
I have noticed the
TransmitterPdu
class extracts theRadioID
field (ref) once inside theheader
field (seeRadioCommsHeader
class), and again separately in theradioNumber
field. this causes an unnecessary shift of unmarshalling by 2 bytes. Removing it from theRadioCommsHeader
class fixes the problem, but so does commenting out the local field to theTransmitterPdu
class, and redirecting all calls to get/set of theRadioID
to the embeddedRadioCommsHeader
instance's field. I'm not sure which way you want to go.Let me know if you're the best POC, or if there's a preferred approach to raising these issues.
The text was updated successfully, but these errors were encountered: