Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransmitterPdu has double extraction of RadioID #11

Open
arrowsmith opened this issue Oct 1, 2021 · 2 comments
Open

TransmitterPdu has double extraction of RadioID #11

arrowsmith opened this issue Oct 1, 2021 · 2 comments

Comments

@arrowsmith
Copy link

Hi again Don @brutzman,

I have noticed the TransmitterPdu class extracts the RadioID field (ref) once inside the header field (see RadioCommsHeader class), and again separately in the radioNumber field. this causes an unnecessary shift of unmarshalling by 2 bytes. Removing it from the RadioCommsHeader class fixes the problem, but so does commenting out the local field to the TransmitterPdu class, and redirecting all calls to get/set of the RadioID to the embedded RadioCommsHeader instance's field. I'm not sure which way you want to go.

Let me know if you're the best POC, or if there's a preferred approach to raising these issues.

@arrowsmith
Copy link
Author

Just in case, I'll tag the other repo members for awareness: @terry-norbraten / @blueoak / @leif81 .

@brutzman
Copy link
Contributor

brutzman commented Dec 29, 2023

We think this is probably fixed by integration of pull request... Recommend adding (or providing) a test for ongoing confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants