HospitalityQ Vendor Fields Revamp #1533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added additional vendor fields for hospitalityq. - Added some validation for multiple/other vendor fields. - Added pytests for multi-vendor field format.
- Added change log file.
- Fixed blank spaces in multi-vendor psql function.
|
@wardi this one is good for review now |
- Changes to hospitalityq.
wardi
reviewed
Nov 15, 2024
wardi
reviewed
Nov 15, 2024
| } | ||
| for k in set(err) | set(expected): | ||
| assert k in err | ||
| assert err[k] == expected[k] |
There was a problem hiding this comment.
instead of raising an error would it be better to strip the empty vendors?
There was a problem hiding this comment.
I just couldn't get the regex the way I wanted it to, so that is why I did an inner regex to raise the error as well
- Field order for hospitalityq vendor fields.
- Removed `vendor_3` fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(pd): hospitalityq vendor fields;